Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Node.js 20 and test in CI #40

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Enable Node.js 20 and test in CI #40

merged 1 commit into from
Dec 13, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Dec 13, 2023

Closes #38

@dcroote dcroote self-assigned this Dec 13, 2023
@dcroote
Copy link
Contributor Author

dcroote commented Dec 13, 2023

The Build, lint and test matrix strategy works as both Node 18 and 20 jobs pass, but the "Required" test is hanging.

I don't have admin access to the repo, but I would strongly guess that this is because there is a branch protection rule for main that requires the Build, lint and test CI step to pass. The reason for it hanging now is I've renamed "Build, lint and test" to include the Node version.

See here for how to edit

@Siegrift
Copy link
Collaborator

We should have the All required checks set in GH settings.
image

This way we don't need to remember to update the GH settings after a new Node version is added/removed.

Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

Nit: Can you change the PR title to Enable Node.js 20 and test in CI?

@dcroote dcroote changed the title feat: enable Node.js 20 and test in CI Enable Node.js 20 and test in CI Dec 13, 2023
@dcroote dcroote merged commit 50e5b2e into main Dec 13, 2023
4 checks passed
@dcroote dcroote deleted the dcroote/issue38 branch December 13, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump node version
2 participants